Conversation
09a1959 to
2296151
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds unit and end-to-end tests to verify that assets from symlinked directories and files pointing outside the workspace root are correctly copied during builds. The feedback points out that the symlink public/outsideAssets created in the e2e test is not cleaned up in the finally block, which could leave a dangling symlink in the workspace.
Ensure asset resolution properly handles symbolic links targeting directories and files located outside the workspace root, as commonly found in monorepo structures with shared packages or hoisted dependencies. Both application and browser builders are covered to prevent regressions when traversing external symlinks, and the end-to-end assets test verifies nested directory copying for out-of-tree targets.
2296151 to
bf12265
Compare
clydin
added
the
action: review
alan-agius4
added
action: merge
|
I see that you just added the |
alan-agius4
added
action: cleanup
2 participants
Ensure asset resolution properly handles symbolic links targeting directories and files located outside the workspace root, as commonly found in monorepo structures with shared packages or hoisted dependencies. Both application and browser builders are covered to prevent regressions when traversing external symlinks, and the end-to-end assets test verifies nested directory copying for out-of-tree targets.