Conversation
clydin
force-pushed
the
fix/vitest-compiler-init
branch
from
September 29, 2026 16:49
ff9ce8c to
31b4ad1
Compare
clydin
marked this pull request as ready for review
September 29, 2026 17:10
There was a problem hiding this comment.
Code Review
This pull request adds an initialization step for the Angular compiler (@angular/compiler) in the Vitest unit test runner by registering a new virtual file and entry point (init-compiler.js) that imports @angular/compiler and prepends it to the Vitest setup files. Additionally, a new integration test has been added to verify that providers injecting services requiring JIT compilation function correctly. No review comments were provided, so there is no feedback to address.
…stBed initialization Provide a dedicated setup file to import '@angular/compiler' prior to TestBed initialization. This ensures the compiler facade is published before 'init-testbed.js' or any shared code-split chunks (such as those configured via 'providersFile') are evaluated, avoiding JIT compilation errors when injectable dependencies are resolved during test initialization.
clydin
force-pushed
the
fix/vitest-compiler-init
branch
from
September 29, 2026 18:05
31b4ad1 to
6aa8648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a dedicated setup file to import '@angular/compiler' prior to TestBed initialization. This ensures the compiler facade is published before 'init-testbed.js' or any shared code-split chunks (such as those configured via 'providersFile') are evaluated, avoiding JIT compilation errors when injectable dependencies are resolved during test initialization.
Closes #31993